Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More TS fixes #5313

Merged
merged 2 commits into from
Sep 28, 2020
Merged

More TS fixes #5313

merged 2 commits into from
Sep 28, 2020

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Sep 28, 2020 •
edited
Loading

Many of the props are now optional because they are injected by react-admin. This was preventing usage such as passing a Show view inside an expand

@djhi djhi added the RFR Ready For Review label Sep 28, 2020
@djhi djhi added this to the 3.9.0 milestone Sep 28, 2020
fzaninotto
fzaninotto requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't use any in existing sanitizeRestProps params signature

@fzaninotto fzaninotto merged commit 7aa5559 into master Sep 28, 2020
@fzaninotto fzaninotto deleted the fix-types branch September 28, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@djhi @fzaninotto @wcoppens @Luwangel