New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing path prop in Tab component type #5386

Merged

fzaninotto merged 1 commit into marmelab:master from nickwaelkens:fix/tab-path-type

Oct 12, 2020

Contributor

nickwaelkens commented Oct 12, 2020

I noticed the Tab component was missing a type for the path prop, which still works fine but makes TypeScript complain.


          Add missing "path" type for Tab component

1671f16

fzaninotto approved these changes

View reviewed changes

fzaninotto merged commit 8a4077b into marmelab:master

fzaninotto added this to the 3.9.5 milestone

Member

fzaninotto commented Oct 12, 2020

Indeed, thanks!

fzaninotto changed the title ~~Add missing "path" type for Tab component~~ Fix missing path prop in Tab component type

nickwaelkens deleted the fix/tab-path-type branch

October 13, 2020 08:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment