Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use React 17 in examples to make sure react-admin works with this version #5453

Merged
merged 7 commits into from Nov 13, 2020
Merged

Use React 17 in examples to make sure react-admin works with this version #5453

merged 7 commits into from Nov 13, 2020

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Oct 29, 2020 •
edited by djhi

  • Upgrade dependencies
  • Make sure the simple example works
  • Make sure the tutorial example works
  • Make sure the demo example works

@fzaninotto fzaninotto added the WIP Work In Progress label Oct 29, 2020
@fzaninotto fzaninotto added this to the 3.10.0 milestone Oct 29, 2020
@fzaninotto fzaninotto changed the base branch from master to next October 29, 2020 08:54
@fzaninotto
Copy link
Member Author

Current status:

image

Base automatically changed from next to master November 3, 2020 13:42
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Nov 6, 2020
@djhi djhi changed the title [WIP] Use React 17 in examples to make sure react-admin works with this version Use React 17 in examples to make sure react-admin works with this version Nov 6, 2020
@djhi djhi mentioned this pull request Nov 6, 2020
Closed
@fzaninotto
Copy link
Member Author

👍

@fzaninotto fzaninotto removed this from the 3.10.0 milestone Nov 9, 2020
@djhi djhi force-pushed the react-17 branch 2 times, most recently from 2337528 to 53a58bf Compare November 9, 2020 15:38
fzaninotto
fzaninotto commented Nov 12, 2020
View reviewed changes
packages/ra-ui-materialui/src/input/AutocompleteInput.tsx Outdated
@@ -446,9 +446,9 @@ const AutocompleteInput: FunctionComponent<AutocompleteInputProps> = props => {
color,
...inputProps
} = getInputProps({
...InputProps,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you make this (breaking) change? It prevents developers from overriding onBlur and onFocus

@fzaninotto fzaninotto merged commit 009b052 into master Nov 13, 2020
@fzaninotto fzaninotto deleted the react-17 branch November 13, 2020 09:20
@fzaninotto fzaninotto added this to the 3.10.1 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fzaninotto @djhi