Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Improve Auth Provider chapter #5493

Merged
merged 4 commits into from Nov 6, 2020
Merged

[Doc] Improve Auth Provider chapter #5493

merged 4 commits into from Nov 6, 2020

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Nov 6, 2020

Closes #5491
Closes #5490

@fzaninotto fzaninotto added the RFR Ready For Review label Nov 6, 2020
docs/Authentication.md Outdated Show resolved Hide resolved
docs/Authentication.md Outdated Show resolved Hide resolved
docs/Authentication.md Outdated Show resolved Hide resolved
docs/Authentication.md Outdated Show resolved Hide resolved
Comment on lines 500 to 501
| `getIdentity` | Get the current user identity | `void` |
| `getPermissions` | Get the current user credentials | `Object` whatever params passed to `usePermissions()` - void for react-admin default routes |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

fzaninotto and others added 2 commits November 6, 2020 11:43
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Comment on lines 499 to 500
| `logout` | Log a user out | `void` |
| `getIdentity` | Get the current user identity | `void` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still use void here for parameters

@djhi djhi merged commit 3e44ce5 into master Nov 6, 2020
@djhi djhi deleted the update-auth-provider-doc branch November 6, 2020 12:58
@djhi djhi added this to the 3.10.0 milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
2 participants