Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getFieldLabelTranslationArgs in ReferenceArrayInput #5606

Conversation

alanpoulain
Copy link
Contributor

The ReferenceArrayInput component is not using the getFieldLabelTranslationArgs function like the FieldTitle component (used by the other inputs: ReferenceInput, TextInput, ...).

The difference is that, if no label is given and if there is no translation, the label is not humanized by default.

Before:
image

After:
image

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@djhi djhi added this to the 3.10.4 milestone Nov 30, 2020
@djhi djhi merged commit 3ac16d2 into marmelab:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants