Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update getIdentity signature in Authentication.md #5734

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

adrien-may
Copy link
Contributor

No description provided.

@djhi
Copy link
Contributor

djhi commented Jan 6, 2021

I fail to see where getIdentity could be called with an error. Would you mind explaining this PR?

@adrien-may
Copy link
Contributor Author

Well, I totally agree with you, that's why I REMOVED error from the signature :)

@djhi
Copy link
Contributor

djhi commented Jan 6, 2021

Indeed! My mistake 😆 Thanks!

@djhi djhi added this to the 3.11.2 milestone Jan 6, 2021
@djhi djhi merged commit ffa83b1 into marmelab:master Jan 6, 2021
@adrien-may adrien-may deleted the patch-2 branch January 8, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants