Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Please login to continue" notification remains after login #5789

Merged
merged 1 commit into from Jan 17, 2021

Conversation

fzaninotto
Copy link
Member

Problem

When an unlogged user tries to access a restricted page, the page calls the dataProvider, which returns a 403 response. This redirects the user to the login page with a "please login to continue" notification. This is correct, but:

  • Users may enter and submit credentials faster than the notification hide delay
  • The restricted page may make several calls to the dataProvider, each returning with a 403, and each pushing a new "please login to continue" notification to be displayed once the previous has hidden.

In both cases, once the user has logged in, they still see the "Please login to continue" notification while the page displays restricted data, which is confusing.

image

Solution

Reset notifications upon login

@fzaninotto fzaninotto added the RFR Ready For Review label Jan 17, 2021
@djhi djhi merged commit 40141c2 into master Jan 17, 2021
@djhi djhi deleted the fix-notification-after-login branch January 17, 2021 13:42
@fzaninotto fzaninotto added this to the 3.11.4 milestone Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants