Add skip navigation button #5804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is no longer a WIP, I believe the code is exactly how the previous MR was before I messed up the. rebase |
fzaninotto
approved these changes
Jan 27, 2021
|
Thanks a lot, this is a great feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
I messed up the rebase, and I'm just opening up a new PR with the same changes.
Description
I've added a button inside of
Layout.tsxthat only displays when the first action a user performs on a RA site is pressing the tab button.This moves the focus into the main content of the website, avoiding having to tab through the top and side menus.
While the functionality is complete, I'm going to write Cypress tests for this functionality.
Notes:
Because navigating to anchors via the
#didn't seem to work nicely withHashRouter, I had to install an node module that exports a custom link. Here's a link to the discussionFortunately the module has no dependencies, and it works out of the box.
I implementing this component similarly to how it's written inside of the Material-UI repo. You can view their implementation here
skip-navigation-smol.mov