Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6050 - type definition for Datagrid rowClick property doesn't allow for functions that return Promise<string> #6060

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

jvert
Copy link
Contributor

@jvert jvert commented Mar 18, 2021

I wasn't sure why there were three separate definitions of RowTypeFunction so I removed two of the duplicates and fixed the remaining one to allow returning Promise<string>

…esn't

allow for functions that return Promise<string>
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.14 milestone Mar 23, 2021
@djhi djhi merged commit 3e48fa5 into marmelab:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants