Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BulkUpdateButton component #6072

Merged
merged 21 commits into from
May 31, 2021
Merged

Added BulkUpdateButton component #6072

merged 21 commits into from
May 31, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Mar 20, 2021

Implements #4474

djhi
djhi requested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/ra-language-french/src/index.ts Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/BulkUpdateButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/BulkUpdateWithConfirmButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/BulkUpdateWithUndoButton.tsx Outdated Show resolved Hide resolved
@WiXSL WiXSL requested a review from djhi April 4, 2021 20:17
@fzaninotto
Copy link
Member

Your PR needs a rebase

fzaninotto
fzaninotto requested changes Apr 13, 2021
View reviewed changes
packages/ra-ui-materialui/src/button/BulkUpdateButton.tsx Outdated Show resolved Hide resolved
docs/List.md Show resolved Hide resolved
@WiXSL WiXSL requested a review from fzaninotto April 13, 2021 22:42
WiXSL and others added 3 commits May 1, 2021 18:40
@WiXSL @fzaninotto
Update packages/ra-language-french/src/index.ts
e252df0 
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
@WiXSL @fzaninotto
Update packages/ra-language-french/src/index.ts
7c82479 
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
Improve code readability
9c451fb
@WiXSL WiXSL requested a review from fzaninotto May 2, 2021 22:32
@WiXSL
Copy link
Contributor Author

WiXSL commented May 31, 2021 •
edited
Loading

@fzaninotto, Is this ok to merge?

@fzaninotto fzaninotto merged commit c7e46cd into marmelab:next May 31, 2021
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.16.0 milestone May 31, 2021
@WiXSL WiXSL deleted the add-bulkupdatebutton branch May 31, 2021 21:36
@fzaninotto fzaninotto mentioned this pull request May 31, 2021
Closed
@mjomble
Copy link
Contributor

mjomble commented Aug 13, 2021

@WiXSL I'm getting errors that seem to be caused by this change:

Material-UI: The `fade` color utility was renamed to `alpha` to better describe its functionality.

You should use `import { alpha } from '@material-ui/core/styles'`

@fzaninotto
Copy link
Member

@mjomble That's a deprecation warning due to the latest material-ui minor update. It's already tracked by #6490.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi Awaiting requested review from djhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WiXSL @fzaninotto @mjomble @djhi