add TS generic support for usePermissions hook #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Jun 3, 2021
.gitignore
Outdated
| @@ -13,3 +13,4 @@ examples/**/static | |||
| examples/**/dist | |||
| cypress/videos | |||
| cypress/screenshots | |||
| .idea | |||
There was a problem hiding this comment.
I have read in some older PRs that this should be in user gitignore, but why is that so? Shouldn't the repository be responsible for what is ignored and what isn't?
There was a problem hiding this comment.
You can have a root .gitignore in your home directory for things specific to your tools.
fzaninotto
approved these changes
Jun 11, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are probably other hooks as well that could use this modification but this is the one that bugs me the most in my project.
I would have made the default value "unknown", to make it more strict, but that would have probably broken a lot of code.