Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to hide input labels with label=false #6381

Merged
merged 11 commits into from
Jun 28, 2021
Merged

Add ability to hide input labels with label=false #6381

merged 11 commits into from
Jun 28, 2021

Conversation

VikrantShirvankar
Copy link
Contributor

@VikrantShirvankar VikrantShirvankar commented Jun 22, 2021 •
edited
Loading

Closes #6352

  • Fixed label issue for FieldTitle component
  • Updated prop type for label in all the components where <FiledTitle /> component is used.

Before - NumberInput with label={false}

Screenshot 2021-06-15 at 11 27 48 PM

@fzaninotto
Copy link
Member

So how about #6361?

@VikrantShirvankar VikrantShirvankar mentioned this pull request Jun 22, 2021
Closed
@VikrantShirvankar
Copy link
Contributor Author

VikrantShirvankar commented Jun 22, 2021 •
edited
Loading

As #6361 is against master branch, we can close that PR. Considering these changes as new feature I have raised this PR against next.

@djhi
Copy link
Contributor

djhi commented Jun 24, 2021

It seems the build is failing. Can you check ?

@VikrantShirvankar
Copy link
Contributor Author

Ok. I will check.

@VikrantShirvankar
Copy link
Contributor Author

VikrantShirvankar commented Jun 24, 2021 •
edited
Loading

I have fixed build failing issue. Could you please run the build once again?

@VikrantShirvankar
Copy link
Contributor Author

Hello,
@djhi, @fzaninotto could you please review this PR.
Do I need to make any changes?

djhi
djhi approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.16.4 milestone Jun 28, 2021
@fzaninotto fzaninotto changed the title Fixed FieldTitle component label issue Add ability to hide input labels with label=false Jun 28, 2021
@fzaninotto fzaninotto merged commit 7997a82 into marmelab:next Jun 28, 2021
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto modified the milestones: 3.16.4, 3.17.0 Jun 28, 2021
@fzaninotto fzaninotto mentioned this pull request Jun 28, 2021
Closed
@VikrantShirvankar VikrantShirvankar deleted the field-title-label branch June 28, 2021 14:19
@fzaninotto fzaninotto mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VikrantShirvankar @fzaninotto @djhi