Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding label for input inside TranslatableInputs #6415

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Allow overriding label for input inside TranslatableInputs #6415

merged 3 commits into from
Jul 6, 2021

Conversation

mjomble
Copy link
Contributor

@mjomble mjomble commented Jul 6, 2021

Fixes #6414

@fzaninotto
Copy link
Member

I think you should update the useTranslatable instead so that getLabel accepts both the source and the label, and pass the correct label to getFieldLabelTranslationArgs

@mjomble
Copy link
Contributor Author

mjomble commented Jul 6, 2021

@fzaninotto done. Also found a mistake in a comment and fixed it.

@djhi djhi added this to the 3.16.5 milestone Jul 6, 2021
@djhi djhi merged commit 36846bf into marmelab:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.5
Development

Successfully merging this pull request may close these issues.

Input label ignored inside TranslatableInputs
3 participants
@mjomble @fzaninotto @djhi