Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eject classes from TextField props #6486

Conversation

mohandes-jiri
Copy link
Contributor

Fix #6394
Note that the Material TextField component has no CSS rule for overridinbg

Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's simpler to just add the following line:

const {
    id: downshiftId, // We want to ignore this to correctly link our label and the input
    value,
    onBlur,
    onChange,
    onFocus,
    ref,
    size,
    color,
+    classes: inputPropsClasses,
    ...inputProps
} = getInputProps({
    onBlur: handleBlur,
    onFocus: handleFocus(openMenu),
    ...InputProps,
});

Could you update your branch version of AutocompleteInput.tsx to the latest and make that change?

@vercel
Copy link

vercel bot commented Dec 25, 2021

@mahdijirofti is attempting to deploy a commit to the Marmelab Team on Vercel.

A member of the Team first needs to authorize it.

@mohandes-jiri
Copy link
Contributor Author

@WiXSL
Thank you for your review.
Done!

@WiXSL WiXSL added the RFR Ready For Review label Dec 26, 2021
@WiXSL
Copy link
Contributor

WiXSL commented Jan 20, 2022

@fzaninotto, is this ok to be merged?

@fzaninotto fzaninotto merged commit 0bde89c into marmelab:master Jan 21, 2022
@fzaninotto fzaninotto added this to the v3.19.7 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutocompleteInput cause material error when I want customize input style
3 participants