Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Remove FC usage from ra-ui-materialui components #6514

Merged
merged 27 commits into from
Aug 26, 2021
Merged

[RFR] Remove FC usage from ra-ui-materialui components #6514

merged 27 commits into from
Aug 26, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Aug 18, 2021

No description provided.

@WiXSL WiXSL changed the title Remove FC usage from Link component Remove FC usage from components Aug 18, 2021
@WiXSL WiXSL changed the title Remove FC usage from components [WIP] Remove FC usage from components Aug 18, 2021
asvarcas added 17 commits August 18, 2021 10:11
Remove FC usage from FilterList and FilterLiveSearch component
b981ac2
Remove FC usage from Pagination component
9fa718a
Remove FC usage from List related components
d3154dc
Remove FC usage from Button components
4020d19
Remove FC usage from DeleteButton and LoginForm components
0252515
Remove FC usage from BulkExportButton component
4a645f6
Remove FC usage from Form related components
5ba6a57
prettier on DeleteButton component
235e500
prettier on TabbedFormTabs
d427144
Remove FC usage from Layout related components
f656321
Remove FC usage from BooleanField component
b79787a
prettier on BooleanField component
35651f0
Remove FC usage from Fields components
603caea
Revert "Remove FC usage from Fields components"
ef0f0bf 
This reverts commit 603caea.
Remove FC usage from Input components
6bb1f5b
prettier on ReferenceInput
ee58e62
Remove FC usage from FileInput component
45a719c
@WiXSL WiXSL changed the title [WIP] Remove FC usage from components [RFR] Remove FC usage from components Aug 18, 2021
@WiXSL WiXSL changed the title [RFR] Remove FC usage from components [RFR] Remove FC usage from ra-ui-materialui components Aug 18, 2021
djhi
djhi requested changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this!

packages/ra-ui-materialui/src/button/BulkDeleteButton.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/button/DeleteButton.tsx Show resolved Hide resolved
packages/ra-ui-materialui/src/field/BooleanField.tsx Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/DashboardMenuItem.tsx Show resolved Hide resolved
@WiXSL WiXSL requested a review from djhi August 19, 2021 13:22
@WiXSL
Copy link
Contributor Author

WiXSL commented Aug 19, 2021 •
edited
Loading

Thanks for taking the time to do this!

You are welcome!
Some components were missing do to some errors, I'll change them in future PRs

@WiXSL WiXSL requested a review from fzaninotto August 26, 2021 13:30
@WiXSL WiXSL requested a review from fzaninotto August 26, 2021 17:27
@WiXSL WiXSL requested a review from fzaninotto August 26, 2021 19:41
@fzaninotto fzaninotto merged commit 4da50fd into marmelab:master Aug 26, 2021
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.17.3 milestone Aug 26, 2021
@WiXSL WiXSL deleted the remove-fc branch August 26, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi Awaiting requested review from djhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.17.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WiXSL @fzaninotto @djhi @bbenoist