Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Remove FC usage from ra-core components #6515

Merged
merged 6 commits into from
Aug 30, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Aug 18, 2021

No description provided.

@WiXSL WiXSL changed the title Remove FC usage from ra-core components [WIP] Remove FC usage from ra-core components Aug 18, 2021
@WiXSL WiXSL changed the title [WIP] Remove FC usage from ra-core components [RFR] Remove FC usage from ra-core components Aug 18, 2021
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@lukascivil
Copy link

Sorry for the question, guys, but why? what are the real benefits?

@fzaninotto
Copy link
Member

@lukascivil see facebook/create-react-app#8177 for a detailed explanation by the React core team

@djhi djhi added this to the 3.18 milestone Aug 30, 2021
@djhi djhi merged commit a033ba6 into marmelab:master Aug 30, 2021
@djhi
Copy link
Contributor

djhi commented Aug 30, 2021

We should also rename and export many of the current Props interfaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants