Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BooleanInput initialValue overrides existing value from record #6533

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

fzaninotto
Copy link
Member

Closes #6511

@fzaninotto fzaninotto added the RFR Ready For Review label Aug 26, 2021
@DjebbZ
Copy link
Contributor

DjebbZ commented Aug 27, 2021

Testing the fix locally...

@DjebbZ
Copy link
Contributor

DjebbZ commented Aug 27, 2021

Code looks good to me, but I still have the problem. It's either something bad on my side or something I have wrongly specified in the reproduction steps. Will continue looking at it today.

@fzaninotto
Copy link
Member Author

I've tested your codesandbox code locally on the branch with the fix, and on my side I don't see the problem anymore.

@DjebbZ
Copy link
Contributor

DjebbZ commented Aug 27, 2021

I think I had weird build problems, couldn't run my app afterwards. Then other things to do so didn't have time to dig the issue. 100% believe you, if you want to merge and cut a release, feel free :)

@fzaninotto fzaninotto merged commit 038f44c into master Aug 27, 2021
@fzaninotto fzaninotto deleted the fix-boolean-input-initialValue branch August 27, 2021 12:36
@fzaninotto fzaninotto added this to the 3.17.3 milestone Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initialValue on BooleanInput inside ArrayInput resets value of BooleanInput on Edit
2 participants