Update Sidebar to remain fixed #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
fixed-sidebar
branch
from
7525403
to
305f10f
Compare
|
switching to RFR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sidebar.mp4
I've decided not to shift the menu up when the appbar disappears, because in my tests this caused real UX problems (e.g. the menu just clicked moved down because the appbar reappeared and pushed the menu down). I'm not a big fan of the empty space on top of the menu, but we can live with it.
The behavior is weird on Safari (a scroll on the menu scrolls the entire page, but a scroll on the content doesn't scroll the menu) but acceptable.
Closes #4684
Supersedes #4753