Added expandedPanel to Datagrid styles #6596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! As this is a new feature, could you please open a PR against the |
|
Closing in favor of #6606 targeting the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project where I needed to use expandable Datagrid rows and have a different background color on the expanded panel row that appears.
For this purpose, it would be very useful to be able to override the CSS class of these rows, which this PR enables.
Not quite sure about the name
expandedPanel. I also thought aboutexpandedRow, but that seemed ambiguous as it could also mean the original always-visible row the user clicked on in order to make the second row appear.Also, while styling the row element was necessary in my case, other people may need to style the cell instead. Maybe we should make both overridable, but I didn't do that yet.