Feature: Blur input on suggestion create #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrico1234
commented
Oct 7, 2021
| @@ -210,7 +210,16 @@ export const getSuggestionsFactory = ({ | |||
| suggestions = choices; | |||
| } | |||
| } else { | |||
| suggestions = choices.filter(choice => matchSuggestion(filter, choice)); | |||
| if (Array.isArray(selectedItem)) { | |||
There was a problem hiding this comment.
I'm a little unsure about this change.
When I changed CommentEdit's matchSuggestion function it caused this logic to fail,, because it was no longer returning true unconditionally. I then adjusted the logic to not return a suggestion if it matches the filterValue (since there's no point in displaying).
This then breaks the functionality for the AutocompleteArrayInput. SO I've just forked the logic. I'm not happy with this, so I'd love one of the RA core member's thoughts on this
djhi
requested changes
Oct 14, 2021
Comment on lines
279
to
281
| const onCreateNewItem = () => { | ||
| inputEl.current.blur(); | ||
| }; |
There was a problem hiding this comment.
I think we don't need the onCreateNewItem and we can just call inputEl.current.blur(); at the end of the effect which run when the input value changes at L283.
djhi
approved these changes
Oct 14, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6622
Behaviour when optionValue is text
autosuggestion-text.mov
Behaviour when optionValue is function
autosuggestion-function.mov
Behaviour when optionValue is a component
autosuggestion-component.mov
Note: the latter seems to break some behaviour because before
matchSuggestionpreviously always returnedtrue. You can see from the video that the autocomplete doesn't quite work as expected anymore