Add Notification component multiLine prop
#6670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
approved these changes
Oct 13, 2021
djhi
reviewed
Oct 13, 2021
There was a problem hiding this comment.
What about @fzaninotto comment on the previous PR ?
We must switch to a simpler signature: notify(message, options). This can be done in a backwards-compatible way by inspecting the type of the second argument at runtime. TypeScript may get in the way, but it supports multiple call signatures.
edit Just saw the other pr
djhi
requested changes
Oct 14, 2021
djhi
reviewed
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6191