Fix warn when unsaved changes #6719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clebiez
suggested changes
Oct 25, 2021
Clebiez
reviewed
Oct 25, 2021
fzaninotto
requested changes
Oct 25, 2021
| Object.keys(unsavedChanges).forEach(key => | ||
| form.change(key, unsavedChanges[key]) | ||
| const release = history.block(location => { | ||
| const isInsideForm = location.pathname.startsWith( |
There was a problem hiding this comment.
Not true e.g. on a TabbedForm when the user arrives directly in tab 2 and navigates to tab 1
There was a problem hiding this comment.
Damn, you're right. I'll have to figure out how to determine the form root path then
Clebiez
approved these changes
Oct 26, 2021
|
The |
fzaninotto
requested changes
Oct 26, 2021
| const form = useForm(); | ||
| const useWarnWhenUnsavedChanges = ( | ||
| enable: boolean, | ||
| formRootPathname: string |
There was a problem hiding this comment.
this is a breaking change: you add a second compulsory parameter, which isn't set in e.g. SimpleForm
There was a problem hiding this comment.
That's because FormWithRedirect set a default value when it's not provided
Can you elaborate? |
fzaninotto
approved these changes
Nov 10, 2021
|
react-router v6 removed useHistory history.block is not work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6678.
Tasks
Description
The linked issue above was introduced by #6272 that fixed the issue ##6198 introduced by #6005.
However, all those workarounds were in fact necessary because of our implementation for warning users about potential data loss if they tried to leave a page with a form with modified fields. Indeed, the
useWarnWhenUnsavedChangeswas saving the form changes when the form was unmounted because a location change happened. If users cancelled the navigation, then the hook would renavigate to the previous location and reapplied the saved changes.However, re-navigating to the previous location means we refetched the data, reapplied initial values for the loaded record (in case of edit) then reapplied the saved changes. All this lead to several workarounds to manage dirty states that introduced more problems.
This PR uses the history API to trigger the warning. This is better because it happens before the location change so we don't have to save changes and reapply them. This allows us to remove the workarounds.