Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SimpleFormIterator transition animations on add and remove items #6871

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Fix SimpleFormIterator transition animations on add and remove items #6871

merged 1 commit into from
Nov 16, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Nov 16, 2021 •
edited
Loading

Fixes #6764

When react-transition-group change findDOMNode over nodeRef, now nodeRef should point to the transitioning child

Reference: 4.4.0

@djhi
Copy link
Contributor

djhi commented Nov 16, 2021

Nice! Would you mind posting a screencast showing the animation?

@WiXSL
Copy link
Contributor Author

WiXSL commented Nov 16, 2021

Screencast: https://drive.google.com/file/d/1QDVmkcZexlxXFqfRdFwqfXUJuthgTmMJ/view?usp=sharing

@djhi djhi added this to the 3.19.1 milestone Nov 16, 2021
@djhi djhi merged commit 1d21d00 into master Nov 16, 2021
@djhi djhi deleted the fix-sfi-animation branch November 16, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.19.1
Development

Successfully merging this pull request may close these issues.

SimpleFormIterator animations are broken
2 participants
@WiXSL @djhi