Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update useGetMany loading/loaded state #6913

Merged
merged 9 commits into from Mar 15, 2022
Merged

Update useGetMany loading/loaded state #6913

merged 9 commits into from Mar 15, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Nov 28, 2021 •
edited

Fixes #6420
Supersedes #6509

@fzaninotto
Copy link
Member

tests fail

@vercel vercel bot temporarily deployed to Preview – react-admin-storybook January 30, 2022 21:20 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook January 30, 2022 22:56 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook January 30, 2022 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook January 30, 2022 23:19 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook January 31, 2022 00:43 Inactive
WiXSL
WiXSL commented Jan 31, 2022
View reviewed changes
Copy link
Contributor Author

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good enough.
Fixes loading but doesn't fix the reported use case which uses load

@vercel vercel bot temporarily deployed to Preview – react-admin-storybook January 31, 2022 11:20 Inactive
@WiXSL WiXSL added the RFR Ready For Review label Jan 31, 2022
@WiXSL
Copy link
Contributor Author

WiXSL commented Jan 31, 2022

Ready for review

@WiXSL WiXSL added this to the v3.19.8 milestone Jan 31, 2022
@fzaninotto fzaninotto removed this from the v3.19.8 milestone Feb 11, 2022
@WiXSL WiXSL added this to the 3.19.9 milestone Feb 16, 2022
@fzaninotto fzaninotto removed this from the 3.19.9 milestone Feb 17, 2022
@djhi djhi added this to the 3.19.11 milestone Mar 15, 2022
@djhi djhi merged commit fc0d8dd into master Mar 15, 2022
@djhi djhi deleted the fix-usegetmany-state branch March 15, 2022 09:48
@WiXSL WiXSL mentioned this pull request Aug 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.19.11
Development

Successfully merging this pull request may close these issues.

useGetMany loading/loaded state does not change when query updated
3 participants
@WiXSL @fzaninotto @djhi