Introduce a new AutocompleteInput based on MUI Autocomplete #6924

djhi · 2021-12-02T09:46:11Z

Avoid breaking change for optionText and leverage the inputText prop we had in previous version

djhi · 2021-12-03T16:53:25Z

packages/ra-ui-materialui/src/input/AutocompleteInput.spec.tsx

@@ -23,23 +23,8 @@ describe('<AutocompleteInput />', () => {
        resource: 'users',
    };

-    it('should use a Downshift', () => {


Removed because we don't want to test mui autocomplete

djhi · 2021-12-03T16:54:07Z

packages/ra-ui-materialui/src/input/AutocompleteInput.spec.tsx

@@ -645,37 +632,6 @@ describe('<AutocompleteInput />', () => {
        await waitFor(() => expect(queryAllByRole('option').length).toEqual(1));
    });

-    it('passes options.suggestionsContainerProps to the suggestions container', () => {


mui autocomplete provide its own ways to customize the underlying components

djhi · 2021-12-03T16:54:46Z

packages/ra-ui-materialui/src/input/AutocompleteInput.spec.tsx

@@ -694,60 +650,6 @@ describe('<AutocompleteInput />', () => {
        });
    });

-    it('should not render a LinearProgress if loading is true and a second has not passed yet', () => {


Mui autocomplete has its own loading mechanism. Maybe we should check we don't set its loading prop unless a second has passed

I see that you did it, am I wrong?

vercel · 2021-12-06T14:16:01Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-admin – ./examples/simple

🔍 Inspect: https://vercel.com/marmelab/react-admin/9hDLVn7GPcfw2AVyC7MJ4wb1NwGv
✅ Preview: https://react-admin-git-mui-autocomplete-marmelab.vercel.app

react-admin-storybook – ./

🔍 Inspect: https://vercel.com/marmelab/react-admin-storybook/AnBNcNU69HiYkbb8qoLuSJUbri5Y
✅ Preview: https://react-admin-storybook-git-mui-autocomplete-marmelab.vercel.app

[Deployment for 0bb5b2e failed]

fzaninotto · 2021-12-07T13:22:13Z

I see a UI bug in the Storybook: in the "inside Reference Input" srtory, when typing text, the choices are briefly emptied before being filled with matching choices. I think you should use the keepPreviousData option in useGetList (once it's handled by react-query, of course)

fzaninotto

Great! 💯

cypress/integration/edit.js

examples/simple/src/comments/CommentEdit.tsx

packages/ra-ui-materialui/src/input/AutocompleteInput.tsx

packages/ra-ui-materialui/src/input/SelectArrayInput.tsx

packages/ra-ui-materialui/src/input/SelectInput.tsx

fzaninotto · 2021-12-07T13:33:44Z

packages/ra-ui-materialui/src/input/AutocompleteInput.spec.tsx

@@ -694,60 +650,6 @@ describe('<AutocompleteInput />', () => {
        });
    });

-    it('should not render a LinearProgress if loading is true and a second has not passed yet', () => {


I see that you did it, am I wrong?

WiXSL

Editing a Post In simple example:

I just set a value, and then re-open the AutocompleteInput

UPGRADE.md

djhi · 2021-12-08T11:56:01Z

Editing a Post In simple example:

I just set a value, and then re-open the AutocompleteInput

Good catch!

Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>

UPGRADE.md

Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>

WiXSL · 2021-12-08T12:35:20Z

docs/Inputs.md

@@ -662,17 +667,6 @@ import { AutocompleteInput, ReferenceInput } from 'react-admin';
 </ReferenceInput>
 ```

-Lastly, would you need to override the props of the suggestion's container (a `Popper` element), you can specify them using the `options.suggestionsContainerProps`. For example:


Since suggestionsContainerProps was introduced by react-admin, shouldn't we clarify how to upgrade this feature?

That's in the MUI documentation, I don't think we should include it

WiXSL · 2021-12-08T14:31:53Z

The vercel deployment doesn't have the authors ArrayInput in Post form and lacks the User menu

djhi · 2021-12-08T14:33:57Z

The vercel deployment doesn't have the authors ArrayInput in Post form and lacks the User menu

You have to log in with admin/password

WiXSL · 2021-12-08T14:35:08Z

I was trying it locally and it caught my attention, you are right

I was trying it locally and it caught my attention, you are right

UPGRADE.md

Travis CI added 4 commits December 2, 2021 10:45

Introduce a new AutocompleteInput based on MUI Autocomplete

55cfe19

Add translations, allow custom option rendering

f94b669

Add Autocomplete Story for usage in ReferenceInput

7e3121d

Add more stories and fix some tests

e49fa56

djhi commented Dec 3, 2021

View reviewed changes

djhi mentioned this pull request Dec 4, 2021

4.0 Roadmap #5933

Closed

djhi and others added 8 commits December 4, 2021 14:27

Fix all tests

4693618

Revert unecessary changes in simple example

893a8d5

Fix simple example

c9f8adb

Revert unecessay changes

217571e

Fix SelectInput

10a411b

Fix e2e tests

59af052

Remove unnecessay file

9f6499b

Better Creation Support (with maching story)

e59a133

djhi marked this pull request as ready for review December 6, 2021 11:08

djhi added the RFR Ready For Review label Dec 6, 2021

Trigger Build

9db9840

vercel bot deployed to Preview – react-admin December 6, 2021 14:16 View deployment

vercel bot deployed to Preview – react-admin-storybook December 6, 2021 14:16 View deployment

djhi added WIP Work In Progress and removed RFR Ready For Review labels Dec 7, 2021

fzaninotto requested changes Dec 7, 2021

View reviewed changes

Travis CI added 2 commits December 7, 2021 16:11

Revert unnecessary breaking change

87f899a

Update documentation

211a2cf

vercel bot deployed to Preview – react-admin December 7, 2021 17:03 View deployment

vercel bot had a problem deploying to Preview – react-admin-storybook December 7, 2021 17:03 Failure

Backport useWarnWhenUnsavedChanges fixes

48b99cb

vercel bot deployed to Preview – react-admin December 8, 2021 11:05 View deployment

vercel bot temporarily deployed to Preview – react-admin-storybook December 8, 2021 11:05 Inactive

WiXSL reviewed Dec 8, 2021

View reviewed changes

WiXSL suggested changes Dec 8, 2021

View reviewed changes

UPGRADE.md Outdated Show resolved Hide resolved

Update UPGRADE.md

dd163e6

Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>

vercel bot deployed to Preview – react-admin December 8, 2021 11:56 View deployment

vercel bot temporarily deployed to Preview – react-admin-storybook December 8, 2021 11:56 Inactive

WiXSL suggested changes Dec 8, 2021

View reviewed changes

UPGRADE.md Outdated Show resolved Hide resolved

Update UPGRADE.md

3bf9a1d

Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>

vercel bot temporarily deployed to Preview – react-admin-storybook December 8, 2021 12:13 Inactive

vercel bot deployed to Preview – react-admin December 8, 2021 12:13 View deployment

WiXSL reviewed Dec 8, 2021

View reviewed changes

Ensure we don't show duplicate choices

de4d93b

vercel bot temporarily deployed to Preview – react-admin-storybook December 8, 2021 14:20 Inactive

vercel bot deployed to Preview – react-admin December 8, 2021 14:20 View deployment

WiXSL approved these changes Dec 8, 2021

View reviewed changes

fzaninotto reviewed Dec 8, 2021

View reviewed changes

UPGRADE.md Outdated Show resolved Hide resolved

Update UPGRADE.md

28bdf2c

vercel bot temporarily deployed to Preview – react-admin-storybook December 8, 2021 17:07 Inactive

vercel bot deployed to Preview – react-admin December 8, 2021 17:07 View deployment

fzaninotto approved these changes Dec 8, 2021

View reviewed changes

fzaninotto merged commit b7e4ed9 into next Dec 8, 2021

fzaninotto deleted the mui-autocomplete branch December 8, 2021 17:09

fzaninotto added this to the 4.0.0-alpha.1 milestone Feb 11, 2022

fzaninotto mentioned this pull request Mar 12, 2024

AutocompleteInput don't keep focus with mouse #9715

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce a new AutocompleteInput based on MUI Autocomplete #6924

Introduce a new AutocompleteInput based on MUI Autocomplete #6924

djhi commented Dec 2, 2021 •

edited

djhi Dec 3, 2021

djhi Dec 3, 2021

djhi Dec 3, 2021 •

edited

fzaninotto Dec 7, 2021

vercel bot commented Dec 6, 2021 •

edited

fzaninotto commented Dec 7, 2021

fzaninotto left a comment

fzaninotto Dec 7, 2021

WiXSL left a comment •

edited

djhi commented Dec 8, 2021

WiXSL Dec 8, 2021 •

edited

djhi Dec 8, 2021

WiXSL commented Dec 8, 2021

djhi commented Dec 8, 2021

WiXSL commented Dec 8, 2021

Introduce a new AutocompleteInput based on MUI Autocomplete #6924

Introduce a new AutocompleteInput based on MUI Autocomplete #6924

Conversation

djhi commented Dec 2, 2021 • edited

djhi Dec 3, 2021

Choose a reason for hiding this comment

djhi Dec 3, 2021

Choose a reason for hiding this comment

djhi Dec 3, 2021 • edited

Choose a reason for hiding this comment

fzaninotto Dec 7, 2021

Choose a reason for hiding this comment

vercel bot commented Dec 6, 2021 • edited

react-admin – ./examples/simple

react-admin-storybook – ./

fzaninotto commented Dec 7, 2021

fzaninotto left a comment

Choose a reason for hiding this comment

fzaninotto Dec 7, 2021

Choose a reason for hiding this comment

WiXSL left a comment • edited

Choose a reason for hiding this comment

djhi commented Dec 8, 2021

WiXSL Dec 8, 2021 • edited

Choose a reason for hiding this comment

djhi Dec 8, 2021

Choose a reason for hiding this comment

WiXSL commented Dec 8, 2021

djhi commented Dec 8, 2021

WiXSL commented Dec 8, 2021

djhi commented Dec 2, 2021 •

edited

djhi Dec 3, 2021 •

edited

vercel bot commented Dec 6, 2021 •

edited

WiXSL left a comment •

edited

WiXSL Dec 8, 2021 •

edited