Fix select all over multiple pages

[WiXSL]

Fixes #6943

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-admin – ./examples/simple

🔍 Inspect: https://vercel.com/marmelab/react-admin/A2d1bMhyo4Q3sZNJVeWqct4sMpUm
✅ Preview: https://react-admin-git-fix-selectall-marmelab.vercel.app

react-admin-storybook – ./

🔍 Inspect: https://vercel.com/marmelab/react-admin-storybook/6SaRUgBms3hXVRDDFxwWVXdvuv5B
✅ Preview: Failed

[Deployment for 6743f8a failed]

[basukb]

@WiXSL the fix looks good . https://react-admin-git-fix-selectall-marmelab.vercel.app is working now

[basukb]

Looks good . Tested in https://react-admin-git-fix-selectall-marmelab.vercel.app

[fzaninotto]

This solves the problem, but I think the code isn't clear. Why should a row be selected if there is no data?

Take a look at the refactoring I made to the same file in useGetList for a better version of the fix.

react-admin/packages/ra-ui-materialui/src/list/datagrid/DatagridHeader.tsx

Lines 59 to 78 in 1f52ce5

	const handleSelectAll = useCallback(
	event =>
	onSelect(
	event.target.checked
	? selectedIds.concat(
	data
	.filter(
	record => !selectedIds.includes(record.id)
	)
	.filter(record =>
	isRowSelectable
	? isRowSelectable(record)
	: true
	)
	.map(record => record.id)
	)
	: []
	),
	[data, onSelect, isRowSelectable, selectedIds]
	);

[basukb]

May I know when this fix will be released ?

[WiXSL]

Is set in the next milestone
Should be pretty soon