Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize enableGetChoices from ReferenceInput child component #6999

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

ZachSelindh
Copy link
Contributor

When using a SelectInput as a child of a ReferenceInput, and using the prop "enableGetChoices" to prevent an initial call for options, a type error will be thrown:

Warning: React does not recognize the `enableGetChoices` prop on a DOM element.

This PR sanitizes enableGetChoices on ReferenceInput's extant rest props sanitize function.

@vercel vercel bot temporarily deployed to Preview – react-admin-storybook December 15, 2021 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin December 15, 2021 18:31 Inactive
@WiXSL WiXSL added the RFR Ready For Review label Dec 16, 2021
@WiXSL WiXSL added this to the 3.19.5 milestone Dec 16, 2021
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi merged commit 9febf1f into marmelab:master Dec 16, 2021
@ZachSelindh ZachSelindh deleted the sanitize-enableGetChoices-from-RI branch February 15, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants