Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing admin test when running all tests together #7136

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Fix failing admin test when running all tests together #7136

merged 4 commits into from
Jan 25, 2022

Commits on Jan 25, 2022

  1. test: apply some best practices to Admin.spec.tsx

    @thdk
    thdk committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    2b082fe View commit details
    Browse the repository at this point in the history

  2. test: increase timeout for admin test 

    This test otherwise often fails when running all tests. If only running
this test it needs just below the default 5000ms.
    @thdk
    thdk committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    96c0a9e View commit details
    Browse the repository at this point in the history

  3. fix: explicitly set the additional types to be loaded 

    If this is not set here, IDE tools such as VS Code will load all
typescript definitions from all node_modules in the tree.

Since both jest and mocha are in the root node_modules folder and each
of them have a declaration for the describe and it function used in our
tests, it doesn't know which one to take and intellisense is wrong.

This is a common issue in a monorepo using workspaces where all
dependencies of all packages are hoisted in the root folder.
    @thdk
    thdk committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    9b10187 View commit details
    Browse the repository at this point in the history

  4. ci: add @types/node explicitly to tsconfig types property

    @thdk
    thdk committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    c53e214 View commit details
    Browse the repository at this point in the history