[RFR] fix(types): missing resource options label property #7422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aim to solve two things: 1. Using object as type is not recommended as we can not access a property without having Typescript yelling this one can not exist on object (ts2339) 2. As specified on the documentation, the label options is available and use by the react-admin ecosystem. It should be explicitly defined.
soullivaneuh
changed the title
fzaninotto
approved these changes
Mar 23, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aim to solve two things:
property without having Typescript yelling this one can not exist on
object (ts2339)
use by the react-admin ecosystem. It should be explicitly defined.