Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArrayInput Props Type #7571

Merged
merged 1 commit into from May 1, 2022
Merged

Fix ArrayInput Props Type #7571

merged 1 commit into from May 1, 2022

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Apr 20, 2022

ArrayInput passes the props it doesn't use to its first underlying component, FormControl. This PR ensure the ArrayInputProps interface extends the FormControlProps interface. This allows to use the sx prop without TS complaining for instance

@djhi djhi added the RFR Ready For Review label Apr 20, 2022
@djhi djhi added this to the 4.0.2 milestone Apr 20, 2022
@djhi djhi requested a review from slax57 April 20, 2022 14:58
@fzaninotto fzaninotto merged commit 0e93f49 into master May 1, 2022
@fzaninotto fzaninotto deleted the fix-array-input-props-type branch May 1, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djhi @fzaninotto @slax57