Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <Filter> shows filter button even though there is no filter to add #7691

Merged
merged 2 commits into from May 16, 2022
Merged

Fix <Filter> shows filter button even though there is no filter to add #7691

merged 2 commits into from May 16, 2022

Conversation

fzaninotto
Copy link
Member

Closes #7689

@fzaninotto fzaninotto added the RFR Ready For Review label May 15, 2022
djhi
djhi requested changes May 15, 2022
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 There's a linter warning left though

@djhi djhi added this to the 4.0.5 milestone May 16, 2022
@djhi djhi merged commit 384de3c into master May 16, 2022
@djhi djhi deleted the fix-filterbutton-alwayson branch May 16, 2022 06:59
@davidhenley
Copy link
Contributor

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.0.5
Development

Successfully merging this pull request may close these issues.

The FilterButton is present with all filters children having the alwaysOn option being set
3 participants
@fzaninotto @davidhenley @djhi