Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Restructure Translation Documentation #7759

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

djhi
Copy link
Contributor

@djhi djhi commented May 26, 2022

Far from perfect yet but that's a start

@djhi djhi added the RFR Ready For Review label May 26, 2022
@djhi djhi added this to the 4.1.1 milestone May 26, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin May 26, 2022 10:19 Inactive
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, this looks very fine to me, gj! 🙂

docs/TranslationSetup.md Outdated Show resolved Hide resolved
Comment on lines 51 to 56
<li {% if page.path contains 'Translation.md' %} class="active" {% endif %}><a class="nav-link" href="./Translation.html">Introduction</a></li>
<li {% if page.path contains 'Translating.md' %} class="active" {% endif %}><a class="nav-link" href="./Translating.html">Translating The Interface</a></li>
<li {% if page.path contains 'UserLocale.md' %} class="active" {% endif %}><a class="nav-link" href="./UserLocale.html">User Locale</a></li>
<li {% if page.path contains 'useTranslate.md' %} class="active" {% endif %}><a class="nav-link" href="./useTranslate.html"><code>useTranslate</code></a></li>
<li {% if page.path contains 'useLocaleState.md' %} class="active" {% endif %}><a class="nav-link" href="./useLocaleState.html"><code>useLocaleState</code></a></li>
<li {% if page.path contains 'LocalesMenuButton.md' %} class="active" {% endif %}><a class="nav-link" href="./LocalesMenuButton.html"><code>&lt;LocalesMenuButton&gt;</code></a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Translating.md' -> 'TranslationTranslating.md'

And missing 'TranslationSetup.md'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still miss the link to 'TranslationSetup.md' if I'm not mistaken

@slax57
Copy link
Contributor

slax57 commented May 30, 2022

I'd like to wait for @fzaninotto 's approval before merging this one 🙂

@vercel vercel bot temporarily deployed to Preview – react-admin June 7, 2022 22:49 Inactive
@fzaninotto fzaninotto merged commit 34c4c06 into master Jun 8, 2022
@fzaninotto fzaninotto deleted the doc-restructure-translation branch June 8, 2022 07:21
@fzaninotto fzaninotto added this to the 4.1.3 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants