Fix boolean and checkbox inputs don't have focus states (re-add ripple) #7772
+10
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fzaninotto are you happy for me to update the MR to remove the I can also add a section to the documentation to explain that you can disable ripple to improve performance, but with the caveat that the user will need to reimplement the correct focus/active states (and other possible accessibility concerns) |
|
absolutely! |
andrico1234
commented
Jun 4, 2022
| @@ -307,6 +307,16 @@ const MyEdit = () => ( | |||
|
|
|||
| ### `<CloneButton>` | |||
|
|
|||
| ## Performance | |||
There was a problem hiding this comment.
Wasn't sure whether to have this in the button or datagrid component docs, or to create a new top-level page specifically for performance. Happy to go with whatever you folks feel is most appropriate
|
friendly bump @fzaninotto |
fzaninotto
approved these changes
Jun 8, 2022
|
Thanks! |
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7771
https://user-images.githubusercontent.com/17087167/171428166-a9e90c03-c313-49a2-878f-3ac9114ab5dc.mov
https://user-images.githubusercontent.com/17087167/171428222-c88c5c02-646b-415b-b789-ccbaecaa57a2.mov