Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix AutocompleteInput creation props and examples #7844

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[Doc] Fix AutocompleteInput creation props and examples #7844

merged 1 commit into from
Jun 17, 2022

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Jun 16, 2022

Fixes #7822

Todo

  • Remove mention to never used createLabel prop
  • Fix the onCreate example
  • Add example showing how to add a placeholder to explain how creation works (also added in the storybook)

Screenshots

2022-06-16_17-42

@slax57 slax57 added the RFR Ready For Review label Jun 16, 2022
@slax57 slax57 added this to the 4.1.4 milestone Jun 16, 2022
@davidhenley
Copy link
Contributor

davidhenley commented Jun 16, 2022 •
edited
Loading

Hey @slax57 I don't think this should close #7822. I still want to hear your thoughts on it. Thanks!

@fzaninotto fzaninotto merged commit 5836257 into master Jun 17, 2022
@fzaninotto fzaninotto deleted the 7822-autocompleteinput-does-not-respect-createlabel-prop branch June 17, 2022 08:43
@slax57 slax57 mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@antoinefricker antoinefricker antoinefricker approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.1.4
Development

Successfully merging this pull request may close these issues.

AutocompleteInput does not respect createLabel prop
4 participants
@slax57 @davidhenley @fzaninotto @antoinefricker