Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Form throws error when passed a defaultValues function #7888

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

fzaninotto
Copy link
Member

Closes #7887

@fzaninotto fzaninotto added the RFR Ready For Review label Jun 24, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin June 24, 2022 08:50 Inactive
@@ -433,31 +427,75 @@ describe('Form', () => {
expect(onSubmit).toHaveBeenCalledWith({ foo: obj });
});
});
it("should not ignore initial value when it's not of the same type", async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved under describe('defaultValues')

@djhi djhi added this to the 4.1.6 milestone Jun 24, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin June 24, 2022 09:00 Inactive
@djhi djhi merged commit bc0898d into master Jun 24, 2022
@djhi djhi deleted the fix-defaultValues-function branch June 24, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabbedForm defaultValues: Maximum call stack size exceeded
2 participants