assign variable before export default #7926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix eslint warnings - Assign object to a variable before exporting as module default - Assign arrow function to a variable before exporting as module default
|
We tend to use named exports rather than default exports in react-admin. I think the tutorial should be updated accordingly. |
|
same, was thinking of changing them into named exports but then i thought maybe other people like default exports. should i update it? |
|
yes, please, but make sure that the other code snippets, where we import the components, are updated, too. |
|
Should i change the structure of files in tutorial or not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix eslint warnings