Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <SelectInput> loading UI to avoid visual jump #7998

Merged
merged 7 commits into from
Jul 22, 2022

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jul 21, 2022

Closes #7975

Before

Enregistrement.de.l.ecran.2022-07-21.a.21.49.50.mov

After

Enregistrement.de.l.ecran.2022-07-21.a.22.02.43.mov

@fzaninotto fzaninotto added the RFR Ready For Review label Jul 21, 2022
@fzaninotto fzaninotto changed the title Fix SelectInput loading UI to avoid visual jump Fix <SelectInput> loading UI to avoid visual jump Jul 21, 2022
@fzaninotto fzaninotto added WIP Work In Progress and removed RFR Ready For Review labels Jul 21, 2022
@fzaninotto
Copy link
Member Author

I still have to suppress the jump due to the helperText

@fzaninotto fzaninotto added WIP Work In Progress and removed RFR Ready For Review labels Jul 22, 2022
@djhi djhi added this to the 4.2.4 milestone Jul 22, 2022
@djhi djhi merged commit 818e443 into master Jul 22, 2022
@djhi djhi deleted the fix-selectinput-loading-state-design branch July 22, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<SelectInput /> inside <ReferenceInput /> not showing a <LinearProgress /> when loading
3 participants