Fix AutocompleteInput suggestions flicker when used inside ReferenceInput #8037
Conversation
fzaninotto
force-pushed
the
fix-autocomplete-input
branch
from
8bac4d1
to
56093b0
Compare
| @@ -97,6 +97,7 @@ export const useReferenceInputController = <RecordType extends RaRecord = any>( | |||
| }, | |||
| { | |||
| enabled: isGetMatchingEnabled, | |||
| keepPreviousData: true, | |||
There was a problem hiding this comment.
This was the main cause of the flicker
|
FYI We are getting the "The value provided to Autocomplete is invalid." warning again in the console with this on every AutocompleteInput on change.
|
|
@davidhenley II've just tested the simple example in the |
|
I got it when the selected value isn't in the getList call from the data provider that the autocomplete does on load. It only happens when you select a value that isn't in the first 25 or whatever values. What's weird is the warning is about the old value and not the newly selected value. This is with the latest release. So if I have this: <ReferenceInput source="cityCodeId" reference="city-codes">
<AutocompleteInput />
</ReferenceInput>Here are the 2 calls it makes on load of Edit: /city-codes?fiterinfo...
/city-codes?ids=11
Now if I choose the first option I get this error (which is about the previous value) since the option isn't in the available list of options
This was working fine in 4.2.5 and as soon as we updated I get this on every single AutocompleteInput |
|
@fzaninotto updated w pictures and code |
How could you update? This change hasn't been released as it's scheduled for react-admin 4.3, due end of this month. |
|
Sorry, it wasn't this particular change then, another change in 4.2.6. Thanks. |
|
Then please open a new issue, and include a reproduction case based on the simple example codesandbox. https://codesandbox.io/s/github/marmelab/react-admin/tree/master/examples/simple |
Closes #7767