Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FormDataConsumer inside SimpleFormIterator adds empty value #8061

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Fix FormDataConsumer inside SimpleFormIterator adds empty value #8061

merged 2 commits into from
Aug 10, 2022

Conversation

fzaninotto
Copy link
Member

Closes #8059

@fzaninotto fzaninotto added the RFR Ready For Review label Aug 10, 2022
slax57
slax57 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! 🙂
Would it be worth the trouble adding some tests about this though?

@fzaninotto
Copy link
Member Author

there you go

@slax57 slax57 added this to the 4.2.7 milestone Aug 10, 2022
@slax57 slax57 merged commit 959b735 into master Aug 10, 2022
@slax57 slax57 deleted the fix-simpleformiterator-formdataconsumer branch August 10, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.2.7
Development

Successfully merging this pull request may close these issues.

FormDataConsumer inside ArrayInput is adding its source prop to each array item (usually undefined)
2 participants
@fzaninotto @slax57