Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useGetList's onSuccess side effect overriding internal one #8102

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Aug 25, 2022

Problem: Providing a onSuccess side effect to useGetList overrides the default one set by react-admin. This results in the 'getOne' react-query cache data not being populated as they should be (and causes bugs in some EE components).

Solution: Execute both the onSuccess side effects, as it is done in other hooks like useUpdate for instance

@slax57 slax57 added the RFR Ready For Review label Aug 25, 2022
@djhi djhi added this to the 4.3.1 milestone Aug 26, 2022
@djhi djhi merged commit 87838be into master Aug 26, 2022
@djhi djhi deleted the fix-useGetList-onSuccess branch August 26, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants