-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to hide savequery in filter button #8113
Merged
fzaninotto
merged 7 commits into
marmelab:next
from
ogustavo-pereira:feat/add-option-in-filter-button
Sep 1, 2022
Merged
feat: add option to hide savequery in filter button #8113
fzaninotto
merged 7 commits into
marmelab:next
from
ogustavo-pereira:feat/add-option-in-filter-button
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your work! PRs for new features should be set against Could you please update your PR? |
7e209e1
to
37c1528
Compare
37c1528
to
7805029
Compare
@fzaninotto I raised the settings by changing:
|
WiXSL
suggested changes
Aug 30, 2022
fzaninotto
requested changes
Sep 1, 2022
fzaninotto
approved these changes
Sep 1, 2022
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe not the best code suggestion, but the idea would basically be to add a possible flag on the filterbutton to disable the save query. If you guys give me suggestions and allow me to continue with pr I can improve it
Closes #8062