Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to hide savequery in filter button #8113

Merged

Conversation

ogustavo-pereira
Copy link
Contributor

Maybe not the best code suggestion, but the idea would basically be to add a possible flag on the filterbutton to disable the save query. If you guys give me suggestions and allow me to continue with pr I can improve it

Closes #8062

@fzaninotto
Copy link
Member

Thanks for your work! PRs for new features should be set against next rather than master, and should contain not only the code for the feature, but also automated tests and documentation.

Could you please update your PR?

@ogustavo-pereira
Copy link
Contributor Author

@fzaninotto I raised the settings by changing:

  • Storybook
  • Test
  • Docs

docs/FilterButton.md Outdated Show resolved Hide resolved
docs/FilterButton.md Outdated Show resolved Hide resolved
docs/FilterButton.md Outdated Show resolved Hide resolved
@WiXSL WiXSL added the RFR Ready For Review label Aug 30, 2022
@ogustavo-pereira ogustavo-pereira requested review from fzaninotto and WiXSL and removed request for fzaninotto and WiXSL September 1, 2022 14:10
@fzaninotto fzaninotto merged commit c986d68 into marmelab:next Sep 1, 2022
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the possibility to hide savedquery option with property in filter-button
3 participants