Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable components #8145

Merged
merged 87 commits into from
Sep 28, 2022
Merged

Configurable components #8145

merged 87 commits into from
Sep 28, 2022

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Sep 6, 2022 •
edited
Loading

Problem

It's too expensive to ask developers to program a simple change in a web app

Solution

Let end-users do some of the changes via a UI.

Enter no-code.

SimpleListConfigurable

Todo

  • Add context to store the inspector state
  • Add generic Inspector component
  • Add Configurable component to wrap existing components
  • Add lightweight client-side templating engine (lodash.template) Use useTranslate as templating engine
  • Update default i18nProvider to make it capable of doing substitutions
  • Add ability to remove all store settings starting with a given string (useRemoveItemsFromStore)
  • Let SimpleList accept template strings as primaryText, secondaryText, and tertiaryText props
  • Make SimpleList configurable
  • Make Page title configurable
  • Add English translations
  • Add French translations
  • Add tests
  • Add documentation

@WiXSL
Copy link
Contributor

WiXSL commented Sep 6, 2022 •
edited
Loading

Impressive! 🤯

@fzaninotto fzaninotto added the WIP Work In Progress label Sep 6, 2022
slax57
slax57 reviewed Sep 28, 2022
View reviewed changes
packages/ra-core/src/i18n/I18nContext.ts Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/Confirm.tsx
@@ -171,8 +173,4 @@ const StyledDialog = styled(Dialog, {
},
},
},

[`& .${ConfirmClasses.iconPaddingStyle}`]: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you take this into account?

@slax57 slax57 merged commit 517c014 into next Sep 28, 2022
@slax57 slax57 deleted the configurable branch September 28, 2022 12:40
@slax57 slax57 added this to the 4.4.0 milestone Sep 28, 2022
@slax57 slax57 mentioned this pull request Oct 7, 2022
Closed
@slax57 slax57 mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fzaninotto @WiXSL @slax57