Implement emptyText and emptyValue in AutocompleteInput
#8162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiXSL
changed the title
SelectInput and AutocompleteInputemptyValue and emptyText prop from AutocompleteInput
|
We need to keep |
WiXSL
changed the title
emptyValue and emptyText prop from AutocompleteInputemptyText in AutocompleteInput
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
slax57
approved these changes
Sep 23, 2022
WiXSL
commented
Sep 26, 2022
| @@ -458,8 +490,7 @@ If you provided a React element for the optionText prop, you must also provide t | |||
| ]); | |||
|
|
|||
| const isOptionEqualToValue = (option, value) => { | |||
| // eslint-disable-next-line eqeqeq | |||
| return getChoiceValue(option) == getChoiceValue(value); | |||
| return getChoiceValue(option) === getChoiceValue(value); | |||
There was a problem hiding this comment.
This change fixes a test
WiXSL
commented
Sep 26, 2022
| @@ -342,6 +368,12 @@ If you provided a React element for the optionText prop, you must also provide t | |||
| return option?.name; | |||
| } | |||
|
|
|||
| if (!isListItem && option[optionValue || 'id'] === emptyValue) { | |||
There was a problem hiding this comment.
This change prevents the empty choice from getting processed by getRecordRepresentation when isFromReference is true fixing the e2e test
slax57
requested changes
Sep 28, 2022
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
slax57
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8091
emptyTextusageemptyValuewith no support fornullorundefinedSelectInput'semptyValuedocs