Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Clarify incompatibility of SaveButton of type='button' with custom Form's onSubmit #8286

Merged
merged 13 commits into from
Oct 25, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Oct 21, 2022

Fixes #7669

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far, but maybe we should also add a warning to https://marmelab.com/react-admin/SaveButton.html?

docs/EditTutorial.md Outdated Show resolved Hide resolved
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
docs/EditTutorial.md Outdated Show resolved Hide resolved
docs/EditTutorial.md Outdated Show resolved Hide resolved
docs/EditTutorial.md Outdated Show resolved Hide resolved
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New sections in SaveButton's doc seem okay to me 👍

Just small typos here and there 😉

docs/SaveButton.md Outdated Show resolved Hide resolved
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
@fzaninotto fzaninotto merged commit 1536c13 into master Oct 25, 2022
@fzaninotto fzaninotto deleted the doc-onsubmit-savebutton branch October 25, 2022 08:16
@fzaninotto fzaninotto added this to the 4.5.0 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding type="button" to SaveButton overrides custom onSubmit behaviour on TabbedForm
3 participants