Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <CheckboxGroupInput options> prop is ignored #8291

Merged
merged 10 commits into from
Oct 24, 2022
Merged

Fix <CheckboxGroupInput options> prop is ignored #8291

merged 10 commits into from
Oct 24, 2022

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Oct 24, 2022 •
edited
Loading

  • Fix CheckboxGroupInput doc doesn't mention source format
  • Improve usage guidelines
  • Add screenshots to the documentation
  • Add stories to test all props
  • Fix options prop isn't taken into account

@fzaninotto fzaninotto added the RFR Ready For Review label Oct 24, 2022
slax57
slax57 requested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, you should probably change the title of the PR since you are doing more than just documenting the source format.

Otherwise, this is a real improvement of the docs, I love it!

docs/CheckboxGroupInput.md Outdated Show resolved Hide resolved
docs/CheckboxGroupInput.md Outdated Show resolved Hide resolved
docs/CheckboxGroupInput.md Outdated Show resolved Hide resolved
fzaninotto and others added 2 commits October 24, 2022 09:12
@fzaninotto @slax57
Update docs/CheckboxGroupInput.md
fe7bd20 
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
@fzaninotto @slax57
Update docs/CheckboxGroupInput.md
98b4f57 
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
@fzaninotto fzaninotto changed the title [Doc] Fix CheckboxGroupInput doc doesn't mention source format Fix <CheckboxGroupInput options> prop is ignored Oct 24, 2022
@fzaninotto
Copy link
Member Author

@slax57 Thanks for your review! I've taken it all into account.

WiXSL
WiXSL suggested changes Oct 24, 2022
View reviewed changes
docs/CheckboxGroupInput.md Outdated Show resolved Hide resolved
fzaninotto and others added 2 commits October 24, 2022 13:20
@fzaninotto @WiXSL
Update docs/CheckboxGroupInput.md
14ca836 
Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>
@fzaninotto
Update CheckboxGroupInput.md
3bbe22f
@slax57 slax57 added this to the 4.5.0 milestone Oct 24, 2022
@slax57 slax57 merged commit 2e47d9d into master Oct 24, 2022
@slax57 slax57 deleted the doc-checkboaxgroupinput branch October 24, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fzaninotto @WiXSL @slax57