Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <AutocompleteInput> should only add an empty option when there is an emptyText #8305

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Fix <AutocompleteInput> should only add an empty option when there is an emptyText #8305

merged 3 commits into from
Oct 26, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Oct 25, 2022 •
edited
Loading

Fixes #8293

@WiXSL WiXSL added the RFR Ready For Review label Oct 25, 2022
slax57
slax57 requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, it seems to work great!! I haven't been able to find a case where it would not work, so for me it's all good! Nice job 🙂

packages/ra-ui-materialui/src/input/AutocompleteInput.tsx Show resolved Hide resolved
@slax57
Copy link
Contributor

slax57 commented Oct 25, 2022

This PR will make react-admin's AutocompleteInput deal with empty values the same way MUI's Autocomplete does by default, and will allow to fix #8293

@slax57 slax57 changed the title AutocompleteInput emptyText prop not set by default Fix AutocompleteInput should only add an empty option when there is an emptyText Oct 26, 2022
@slax57 slax57 added this to the 4.5.0 milestone Oct 26, 2022
@slax57 slax57 merged commit 8b061cf into master Oct 26, 2022
@slax57 slax57 deleted the fix-emptytext branch October 26, 2022 07:06
@fzaninotto fzaninotto changed the title Fix AutocompleteInput should only add an empty option when there is an emptyText Fix <AutocompleteInput> should only add an empty option when there is an emptyText Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

AutocompleteInput doesn't show 'No options' when empty value is allowed
2 participants
@WiXSL @slax57