Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix navigation panel version in 404.html #8311

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Oct 26, 2022

Problem

navigation.html is included relatively to the current rendered path. But 404.html is at the root, so it always includes the navigation.html file located at the root (hence the latest).

Solution

Use JS to dynamically fetch the navigation side panel and replace the html content by the one fetched. There is no way to do it statically because the current version can only be fetched from the URL, which is unavailable to Jekyll for a 404 error page.

Screenshots

404 navigation version

@slax57 slax57 added the RFR Ready For Review label Oct 26, 2022
@fzaninotto fzaninotto merged commit c290d3f into master Oct 26, 2022
@fzaninotto fzaninotto deleted the docs-404-nav-version branch October 26, 2022 11:38
@fzaninotto fzaninotto added this to the 4.5.0 milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants