Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo] Fix demos use different versions of Vite #8345

Merged
merged 1 commit into from Nov 3, 2022
Merged

[Demo] Fix demos use different versions of Vite #8345

merged 1 commit into from Nov 3, 2022

Conversation

fzaninotto
Copy link
Member

No description provided.

@fzaninotto fzaninotto added the RFR Ready For Review label Nov 2, 2022
@fzaninotto
Copy link
Member Author

Supersedes #8343

@smeng9 smeng9 mentioned this pull request Nov 2, 2022
Closed
WiXSL
WiXSL approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine!

@fzaninotto fzaninotto merged commit 81f9e55 into master Nov 3, 2022
@fzaninotto fzaninotto deleted the vite-consistent branch November 3, 2022 12:38
@fzaninotto fzaninotto added this to the 4.5.1 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fzaninotto @WiXSL