Add SimpleFormConfigurable component #8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fzaninotto
commented
Nov 15, 2022
•
fzaninotto
commented
We need the button to be able to break out of overflow:hidden elements, and there is no other way but to use a popover for that.
fzaninotto
commented
Nov 15, 2022
| sx={{ | ||
| display: 'block', | ||
| '&.RaConfigurable-editMode': { | ||
| margin: '2px', |
There was a problem hiding this comment.
MAde necessary because the outline is invisible for elements used as children of Paper, which has overflow:hidden
fzaninotto
commented
Nov 15, 2022
| useSetInspectorTitle('ra.inspector.datagrid', { _: 'Datagrid' }); | ||
|
|
||
| const [availableColumns] = usePreference<ConfigurableDatagridColumn[]>( |
There was a problem hiding this comment.
refactored to FieldsSelector (which is also used by SimpleFormEditor
fzaninotto
commented
Nov 15, 2022
| </Root> | ||
| <Popover |
There was a problem hiding this comment.
I had to move from Badge to Popover because there is no other way to make the customize button break out of its parent container when that container has overflow:hidden
|
Back to WIP, I forgot unit tests |
|
And Ready For Review |
WiXSL
suggested changes
Nov 16, 2022
Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>
WiXSL
suggested changes
Nov 16, 2022
WiXSL
approved these changes
Nov 17, 2022
slax57
requested changes
Nov 17, 2022
slax57
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.