Fix NumberInput doesn't show helperText with an onBlur prop and mode='onBlur'
#8403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiXSL
changed the title
NumberInput don't show helperText error onBlur if its requiredNumberInput doesn't show helperText error onBlur if its required
WiXSL
commented
Nov 18, 2022
| @@ -46,6 +47,7 @@ export const NumberInput = ({ | |||
| isRequired, | |||
| } = useInput({ | |||
| defaultValue, | |||
| onBlur, | |||
There was a problem hiding this comment.
Not really sure why destructuring onBlur prop solves it, but it does
There was a problem hiding this comment.
It changes what you pass to the MUI TextField (via ...sanitizeInputRestProps(rest))
slax57
approved these changes
Nov 22, 2022
| @@ -46,6 +47,7 @@ export const NumberInput = ({ | |||
| isRequired, | |||
| } = useInput({ | |||
| defaultValue, | |||
| onBlur, | |||
There was a problem hiding this comment.
It changes what you pass to the MUI TextField (via ...sanitizeInputRestProps(rest))
slax57
changed the title
NumberInput doesn't show helperText error onBlur if its requiredNumberInput doesn't show helperText with an onBlur prop and mode='onBlur'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.